feat: Add native support for max_by and min_by#3969
Open
pchintar wants to merge 3 commits intoapache:mainfrom
Open
feat: Add native support for max_by and min_by#3969pchintar wants to merge 3 commits intoapache:mainfrom
pchintar wants to merge 3 commits intoapache:mainfrom
Conversation
Author
|
Hi, so I understand the issue with the formatting of rust files & so I ran cargo fmt --all to address the lint failure. But I don't know what's causing the remaining few couple of errors? |
Contributor
|
@pchintar , you would want to download the logs and grep for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3841 .
Rationale for this change
This change adds native support for
MAX_BYandMIN_BY.These aggregates are commonly used in grouped queries. Without native support, they fall back, which prevents execution from staying within Comet’s aggregation pipeline. This change enables them to run natively and align their behavior with Spark.
What changes are included in this PR?
Added a native implementation for
max_byandmin_by(maxmin_by.rs) using a shared design(value, ordering)pair per groupImplemented
GroupsAccumulatorsupport to integrate with Comet’s grouped aggregation pathCometHashAggregatefor grouped workloadsAdded serialization and planner wiring
MaxBy/MinByCometMaxBy,CometMinBy)QueryPlanSerdeExtended operator support
HashAggregateSortAggregateExecwhere selected by SparkHow are these changes tested?
Validated against Spark for:
Results match Spark semantics, and supported queries execute without any fallback.
Note: I've made the two changes required: 1)Updating the title correctly & 2)Adding the Licence header for maxmin_by.rs