pre-commit trailing whitespace auto clean up#12841
Conversation
Now targetting more files and file types Also minor change to the markdown lint hook since we only have ".md" files
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12841 +/- ##
=========================================
Coverage 18.01% 18.01%
+ Complexity 16459 16458 -1
=========================================
Files 5968 5968
Lines 537218 537218
Branches 65977 65977
=========================================
+ Hits 96801 96802 +1
Misses 429498 429498
+ Partials 10919 10918 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DaanHoogland
left a comment
There was a problem hiding this comment.
looks generally good. one point of attention found.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <svg width="52px" height="45px" viewBox="0 0 52 45" version="1.1" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| <svg width="52px" height="45px" viewBox="0 0 52 45" version="1.1" |
There was a problem hiding this comment.
bit weary about this line, as I don’t see a change in it, but I guess svg are just xml-texts, so soi.
There was a problem hiding this comment.
Pull request overview
Updates the repository’s pre-commit configuration to broaden trailing-whitespace cleanup coverage across more file types (including non-extension README files) and narrows the markdownlint hook’s file matching to .md files, alongside applying whitespace-only fixes to a few existing files.
Changes:
- Expanded
trailing-whitespacehook file matching to includeREADME(no extension) and additional extensions (.config,.erb,.svg). - Adjusted markdownlint hook
filespattern to only match.md. - Applied trailing-whitespace cleanup in several SVG/XML/config/template/README files.
Reviewed changes
Copilot reviewed 1 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
ui/src/assets/icons/dark.svg |
Removes trailing whitespace in SVG header lines. |
tools/utils/database_comparision_during_upgrade/README |
Removes trailing whitespace from usage instructions. |
tools/devcloud4/binary-installation-basic/marvin.cfg.erb |
Removes trailing whitespace in license header comments. |
tools/devcloud4/binary-installation-advanced/marvin.cfg.erb |
Removes trailing whitespace in license header comments. |
plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/App.config |
Removes trailing whitespace in XML comment opener. |
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/App.config |
Removes trailing whitespace in XML comment opener. |
plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/App.config |
Removes trailing whitespace on a blank line. |
.pre-commit-config.yaml |
Broadens trailing-whitespace hook scope and restricts markdownlint matching to .md. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17303 |
Now targetting more files and file types
Also minor change to the markdown lint hook since we only have ".md" files
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Ran
pre-commit run --all-filesHow did you try to break this feature and the system with this change?