Skip to content

pre-commit trailing whitespace auto clean up#12841

Merged
DaanHoogland merged 2 commits intoapache:mainfrom
jbampton:trailing-whitespace-cleanup
Mar 31, 2026
Merged

pre-commit trailing whitespace auto clean up#12841
DaanHoogland merged 2 commits intoapache:mainfrom
jbampton:trailing-whitespace-cleanup

Conversation

@jbampton
Copy link
Copy Markdown
Member

Now targetting more files and file types

Also minor change to the markdown lint hook since we only have ".md" files

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran pre-commit run --all-files

How did you try to break this feature and the system with this change?

Now targetting more files and file types

Also minor change to the markdown lint hook since we only have ".md" files
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.01%. Comparing base (18075ae) to head (e48f99f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12841   +/-   ##
=========================================
  Coverage     18.01%   18.01%           
+ Complexity    16459    16458    -1     
=========================================
  Files          5968     5968           
  Lines        537218   537218           
  Branches      65977    65977           
=========================================
+ Hits          96801    96802    +1     
  Misses       429498   429498           
+ Partials      10919    10918    -1     
Flag Coverage Δ
uitests 3.53% <ø> (ø)
unittests 19.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks generally good. one point of attention found.

<?xml version="1.0" encoding="UTF-8"?>
<svg width="52px" height="45px" viewBox="0 0 52 45" version="1.1"
xmlns="http://www.w3.org/2000/svg"
<svg width="52px" height="45px" viewBox="0 0 52 45" version="1.1"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit weary about this line, as I don’t see a change in it, but I guess svg are just xml-texts, so soi.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s pre-commit configuration to broaden trailing-whitespace cleanup coverage across more file types (including non-extension README files) and narrows the markdownlint hook’s file matching to .md files, alongside applying whitespace-only fixes to a few existing files.

Changes:

  • Expanded trailing-whitespace hook file matching to include README (no extension) and additional extensions (.config, .erb, .svg).
  • Adjusted markdownlint hook files pattern to only match .md.
  • Applied trailing-whitespace cleanup in several SVG/XML/config/template/README files.

Reviewed changes

Copilot reviewed 1 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ui/src/assets/icons/dark.svg Removes trailing whitespace in SVG header lines.
tools/utils/database_comparision_during_upgrade/README Removes trailing whitespace from usage instructions.
tools/devcloud4/binary-installation-basic/marvin.cfg.erb Removes trailing whitespace in license header comments.
tools/devcloud4/binary-installation-advanced/marvin.cfg.erb Removes trailing whitespace in license header comments.
plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/App.config Removes trailing whitespace in XML comment opener.
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/App.config Removes trailing whitespace in XML comment opener.
plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/App.config Removes trailing whitespace on a blank line.
.pre-commit-config.yaml Broadens trailing-whitespace hook scope and restricts markdownlint matching to .md.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbampton
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17303

@DaanHoogland DaanHoogland merged commit 5d95bdd into apache:main Mar 31, 2026
31 of 32 checks passed
@DaanHoogland DaanHoogland added this to the 4.23.0 milestone Mar 31, 2026
@jbampton jbampton deleted the trailing-whitespace-cleanup branch March 31, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants