Fix Host setup when persistent networks exist

[Pearl1594]

Description

This PR fixes: #12718

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.61%. Comparing base (59b6c32) to head (14cb6aa).
⚠️ Report is 1 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/network/dao/NetworkDaoImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #12751   +/-   ##
=========================================
  Coverage     17.60%   17.61%           
- Complexity    15676    15677    +1     
=========================================
  Files          5918     5918           
  Lines        531667   531668    +1     
  Branches      65001    65001           
=========================================
+ Hits          93617    93628   +11     
+ Misses       427491   427481   -10     
  Partials      10559    10559           

Flag	Coverage Δ
uitests	3.70% <ø> (ø)
unittests	18.68% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sureshanaparti]

clgtm

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17024

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-15577)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50598 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12751-t15577-kvm-ol8.zip
Smoke tests completed. 146 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:teardown	Error	1.13	test_list_ids_parameter.py
test_01_snapshot_root_disk	Error	3.85	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	46.70	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	46.71	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	Error	27.55	test_snapshots.py
test_01_snapshot_usage	Error	28.76	test_usage.py
test_01_vpn_usage	Error	1.09	test_usage.py

[weizhouapache]

code lgtm

[vladimirpetrov]

LGTM based on manual testing. Reproduced on upstream 4.22 and confirmed on the patched version.

[vladimirpetrov]

@blueorangutan test

[blueorangutan]

@vladimirpetrov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[sureshanaparti]

@Pearl1594 is this PR ready, or any further changes needed?

[blueorangutan]

[SF] Trillian test result (tid-15681)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57657 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12751-t15681-kvm-ol8.zip
Smoke tests completed. 146 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:teardown	Error	1.20	test_list_ids_parameter.py
test_01_snapshot_root_disk	Error	4.96	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	46.85	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	46.86	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	Error	28.89	test_snapshots.py
test_01_snapshot_usage	Error	25.87	test_usage.py
test_01_vpn_usage	Error	1.10	test_usage.py

[DaanHoogland]

ping @Pearl1594