Skip to content

Fix aoco_relation_size() using wrong snapshot to read pg_aocsseg #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yjhjstz merged 1 commit into from
Apr 9, 2026
+13 −4
Merged

Fix aoco_relation_size() using wrong snapshot to read pg_aocsseg #1668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/backend/access/aocs/aocsam_handler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2044,15 +2044,25 @@ static uint64
aoco_relation_size(Relation rel, ForkNumber forkNumber)
{
AOCSFileSegInfo **allseg;
Snapshot snapshot;
uint64 totalbytes = 0;
int totalseg;

if (forkNumber != MAIN_FORKNUM)
return totalbytes;

snapshot = RegisterSnapshot(GetLatestSnapshot());
allseg = GetAllAOCSFileSegInfo(rel, snapshot, &totalseg, NULL);
/*
* Pass NULL as snapshot so that GetAllAOCSFileSegInfo -> systable_beginscan
* uses GetCatalogSnapshot() internally. This is consistent with
* appendonly_relation_size() for AO row tables and ensures pg_aocsseg
* entries are visible even when called within the same transaction that
* populated them (e.g. ALTER TABLE SET DISTRIBUTED BY).
*
* Using GetLatestSnapshot() here previously caused the metadata to be
* invisible on QE segments during in-transaction redistribution, leading
* to a zero return value and a subsequent assertion failure in
* vac_update_relstats().
*/
allseg = GetAllAOCSFileSegInfo(rel, NULL, &totalseg, NULL);
for (int seg = 0; seg < totalseg; seg++)
{
for (int attr = 0; attr < RelationGetNumberOfAttributes(rel); attr++)
Expand All @@ -2079,7 +2089,6 @@ aoco_relation_size(Relation rel, ForkNumber forkNumber)
FreeAllAOCSSegFileInfo(allseg, totalseg);
pfree(allseg);
}
UnregisterSnapshot(snapshot);

return totalbytes;
}
Expand Down
Loading