Revert "Fix copy to replicated table display copy number is incorrect."#1667
Open
robertmu wants to merge 1 commit intoapache:mainfrom
Open
Revert "Fix copy to replicated table display copy number is incorrect."#1667robertmu wants to merge 1 commit intoapache:mainfrom
robertmu wants to merge 1 commit intoapache:mainfrom
Conversation
This reverts commit cfd2ce4. The reverted change normalizes COPY FROM row counts on replicated tables by dividing by the number of segments. This causes inconsistent and misleading completion tags (e.g. COPY TO reports N*segments while COPY FROM reports N for the same replicated data). It also produces arbitrary results in ON SEGMENT workflows used by backup/restore. For example, on a 4-segment cluster, loading three 100-row files and one empty file can report 75 rows ((100*3)/4), which is not a meaningful load count. Restore Greenplum-compatible behavior by reporting aggregated completed rows. Refs: - apache#1298 - apache/cloudberry-backup#36
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi, @robertmu welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit cfd2ce4.
The reverted change normalizes COPY FROM row counts on replicated tables by dividing by the number of segments. This causes inconsistent and misleading completion tags (e.g. COPY TO reports N*segments while COPY FROM reports N for the same replicated data).
It also produces arbitrary results in ON SEGMENT workflows used by backup/restore. For example, on a 4-segment cluster, loading three 100-row files and one empty file can report 75 rows ((100*3)/4), which is not a meaningful load count.
Restore Greenplum-compatible behavior by reporting aggregated completed rows.
Refs: