Testcontainers: Add Oracle JDBC test#104
Merged
ostinru merged 2 commits intoapache:mainfrom Apr 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Oracle 23 Testcontainers-based JDBC integration tests to validate Cloudberry → PXF → JDBC type round-tripping, and updates docs/dependencies to support Oracle connectivity.
Changes:
- Add Oracle JDBC driver dependencies for PXF and automation tests.
- Introduce an
OracleContainerwrapper and new TestNG test exercising read/write of common types. - Update Oracle JDBC PXF documentation to reference Apache Cloudberry and add FDW-based examples.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| server/pxf-jdbc-drivers/build.gradle | Adds Oracle JDBC-related dependencies to the PXF JDBC drivers module. |
| docs/content/jdbc_pxf_oracle.html.md.erb | Updates Oracle JDBC setup docs for Cloudberry and adds FDW usage examples. |
| automation/src/test/java/org/apache/cloudberry/pxf/automation/features/jdbc/JdbcOracleTest.java | Adds Testcontainers-based Oracle JDBC read/write type coverage. |
| automation/src/main/java/org/apache/cloudberry/pxf/automation/testcontainers/OracleContainer.java | Introduces an Oracle Free container wrapper and JDBC URL helpers. |
| automation/sqlrepo/features/jdbc/oracle/** | Adds SQL + expected results for read/write regression tests. |
| automation/pom.xml | Adds Oracle JDBC and Oracle-Free Testcontainers dependencies for automation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ation/src/main/java/org/apache/cloudberry/pxf/automation/testcontainers/OracleContainer.java
Show resolved
Hide resolved
...ation/src/main/java/org/apache/cloudberry/pxf/automation/testcontainers/OracleContainer.java
Show resolved
Hide resolved
...ation/src/main/java/org/apache/cloudberry/pxf/automation/testcontainers/OracleContainer.java
Show resolved
Hide resolved
automation/src/test/java/org/apache/cloudberry/pxf/automation/features/jdbc/JdbcOracleTest.java
Show resolved
Hide resolved
MisterRaindrop
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Oracle JDBC tests
Add new tests to cover Cloudberry -> PXF -> JDBC path. In this test we are verifying that main data Cloudberry and Oracle types can be converted back and forth.
Test covers Oracle 23 (only supported by Testcontainers version).