Skip to content

Testcontainers: Add Oracle JDBC test#104

Merged
ostinru merged 2 commits intoapache:mainfrom
ostinru:jdbc-oracle
Apr 14, 2026
Merged

Testcontainers: Add Oracle JDBC test#104
ostinru merged 2 commits intoapache:mainfrom
ostinru:jdbc-oracle

Conversation

@ostinru
Copy link
Copy Markdown
Collaborator

@ostinru ostinru commented Apr 13, 2026

Add Oracle JDBC tests

Add new tests to cover Cloudberry -> PXF -> JDBC path. In this test we are verifying that main data Cloudberry and Oracle types can be converted back and forth.

Test covers Oracle 23 (only supported by Testcontainers version).

@ostinru ostinru marked this pull request as ready for review April 13, 2026 16:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds Oracle 23 Testcontainers-based JDBC integration tests to validate Cloudberry → PXF → JDBC type round-tripping, and updates docs/dependencies to support Oracle connectivity.

Changes:

  • Add Oracle JDBC driver dependencies for PXF and automation tests.
  • Introduce an OracleContainer wrapper and new TestNG test exercising read/write of common types.
  • Update Oracle JDBC PXF documentation to reference Apache Cloudberry and add FDW-based examples.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
server/pxf-jdbc-drivers/build.gradle Adds Oracle JDBC-related dependencies to the PXF JDBC drivers module.
docs/content/jdbc_pxf_oracle.html.md.erb Updates Oracle JDBC setup docs for Cloudberry and adds FDW usage examples.
automation/src/test/java/org/apache/cloudberry/pxf/automation/features/jdbc/JdbcOracleTest.java Adds Testcontainers-based Oracle JDBC read/write type coverage.
automation/src/main/java/org/apache/cloudberry/pxf/automation/testcontainers/OracleContainer.java Introduces an Oracle Free container wrapper and JDBC URL helpers.
automation/sqlrepo/features/jdbc/oracle/** Adds SQL + expected results for read/write regression tests.
automation/pom.xml Adds Oracle JDBC and Oracle-Free Testcontainers dependencies for automation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ostinru ostinru merged commit 3935e9b into apache:main Apr 14, 2026
103 of 115 checks passed
@ostinru ostinru deleted the jdbc-oracle branch April 14, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants