CAMEL-23528: validate property names when building MATCH/DELETE WHERE clause#23258
Open
oscerd wants to merge 1 commit into
Open
CAMEL-23528: validate property names when building MATCH/DELETE WHERE clause#23258oscerd wants to merge 1 commit into
oscerd wants to merge 1 commit into
Conversation
… clause Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (10 modules)
|
davsclaus
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Neo4jProducer.retrieveNodes()anddeleteNode()build the CypherWHEREclause from theCamelNeo4jMatchPropertiesJSON map. Property values are passed as bound query parameters ($paramN), but property names (the JSON keys) were concatenated into the query string verbatim. A property name containing whitespace or characters that are not valid Cypher identifier characters produced a malformed or unintended query instead of a clear error.Changes
^[A-Za-z_][A-Za-z0-9_]*$) applied in bothretrieveNodes()anddeleteNode()before the name is used to build the clause.IllegalArgumentException, wrapped inNeo4jOperationExceptionconsistent with the existing JSON-parse error handling.This makes property-name handling consistent with the already-parameterised value handling and ensures invalid input fails fast with a meaningful message.
Jira: https://issues.apache.org/jira/browse/CAMEL-23528
Claude Code on behalf of Andrea Cosentino