[Python] Create temporary dataset with a 24 hour ttl. - #39615
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
jrmccluskey
left a comment
There was a problem hiding this comment.
LGTM mod the formatting change
Co-authored-by: Jack McCluskey <34928439+jrmccluskey@users.noreply.github.com>
|
Done! thanks for the review |
| # Tables created in the dataset auto-expire after this duration if not | ||
| # explicitly deleted, acting as a safety net for orphaned temp tables | ||
| # (e.g. pipeline crash before cleanup runs). | ||
| _DEFAULT_TABLE_EXPIRATION_MS = 24 * 60 * 60 * 1000 |
There was a problem hiding this comment.
Isn't there a genuine data loss concern if there is a long running job that some temp tables are materialized, and expired before all of them finalized to destination table?
There was a problem hiding this comment.
There was a problem hiding this comment.
I haven't encountered a load/export job that takes longer than a day. But I guess it's possible. A 7-day expiration window would be safer
Create temporary dataset with a 24 hour ttl
Tables created in the dataset auto-expire after 24 hours if not explicitly deleted,
acting as a safety net for orphaned temp tables (e.g. pipeline crash before cleanup runs).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.