Add Delta Lake to Iceberg Yaml blueprint IT - #39549
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
61e34ca to
ede8394
Compare
|
Reminder, please take a look at this pr: @claudevdm @Abacn |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
|
damccorm
left a comment
There was a problem hiding this comment.
Thanks, the example looks good to me, just had a naming question (also there are pr conflicts)
| test_files_dir = 'extended_tests/messaging' | ||
| break | ||
| case 'blueprints': | ||
| test_files_dir = 'extended_tests/blueprints' |
There was a problem hiding this comment.
Are we overloading the term blueprint here? These aren't the blueprints that are being served as part of Dataflow's job builder, right?
Maybe e2e would be a more appropriate folder name
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.