Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a test failure in FileBasedSinkTest by ensuring that default pipeline options are correctly initialized before the tests run. This prevents potential null pointer exceptions or configuration errors during file system operations within the test suite. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
| @Rule public TemporaryFolder tmpFolder = new TemporaryFolder(); | ||
|
|
||
| @Before | ||
| public void setUp() { |
There was a problem hiding this comment.
This was a regression of #36781. I think we should fix the NPE itself
java.lang.NullPointerException: Lineage not initialized. FileSystems.setDefaultPipelineOptions must be called first.
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:1045)
at org.apache.beam.sdk.metrics.Lineage.getSinks(Lineage.java:132)
at org.apache.beam.sdk.io.FileSystems.reportSinkLineage(FileSystems.java:426)
at org.apache.beam.sdk.io.FileSystems.reportSinkLineage(FileSystems.java:408)
at
...
to make setDefaultPipelineOptions not required to access Lineage.getSources / Lineage.getSinks
cc: @shnapz
shnapz
left a comment
There was a problem hiding this comment.
Initially I did not anticipate Lineage to be used outside of setDefaultPipelineOptions initialization, but this makes sense!
|
Run Java_GCP_IO_Direct PreCommit |
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Fixes issue with test via #36781.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.