Conversation
Preserve unknown properties when parsing and serializing primitive schema objects. This keeps extensions such as Iceberg's adjust-to-utc annotation intact across schema JSON round trips.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Avro C++ currently drops custom attributes attached directly to primitive
schema objects.
The schema compiler does not collect unknown properties from primitive objects,
and
NodePrimitive::printJsononly emits an object for logical types withoutserializing primitive custom attributes.
This is required by integrations such as Apache Iceberg. Iceberg uses the
adjust-to-utcproperty to distinguishtimestampfromtimestamptz, whileboth types use Avro
longwith thetimestamp-microslogical type.This change:
attributes.
Verifying this change
This change added tests and can be verified as follows:
adjust-to-utcproperty.Documentation