ATLAS-4764: CuratorFrameWork should work only with Zookeeper HA mode#587
Open
pareshddevalia wants to merge 1 commit intoapache:masterfrom
Open
ATLAS-4764: CuratorFrameWork should work only with Zookeeper HA mode#587pareshddevalia wants to merge 1 commit intoapache:masterfrom
pareshddevalia wants to merge 1 commit intoapache:masterfrom
Conversation
Testing : Tested locally. By default atlas.server.ha.enabled=false Docker tested with Atlas startup.
pareshddevalia
force-pushed
the
ATLAS-4764
branch
from
9af34a2 to
2ade7f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Disable ZooKeeper/Curator initialization when HA is not enabled: CuratorFactory now initializes CuratorFramework only when atlas.server.ha.enabled is explicitly present and set to true. This avoids attempting ZooKeeper connections in non-HA setups.
Remove legacy code for ZooKeeper connect string: HAConfiguration.getZookeeperProperties() no longer falls back to atlas.kafka.zookeeper.connect when atlas.server.ha.zookeeper.connect is missing; it now uses an empty connect string
How was this patch tested?
Unit tests: Updated/added tests for HAConfiguration and CuratorFactory (locally).
Docker validation: Verified Atlas startup with default atlas.server.ha.enabled=false