GH-48590: [C++] Modernize type traits using C++20 concepts (Preliminary)#49348
Open
abhishek593 wants to merge 1 commit intoapache:mainfrom
Open
GH-48590: [C++] Modernize type traits using C++20 concepts (Preliminary)#49348abhishek593 wants to merge 1 commit intoapache:mainfrom
abhishek593 wants to merge 1 commit intoapache:mainfrom
Conversation
aacbfe7 to
943f82b
Compare
Contributor
Author
|
@pitrou I just want to post my analysis here. The code so far what I have submitted is standard-compliant (compiles on gcc-14, gcc-15, clang). But the check C++ / C++ Minimal Build Example fails which uses gcc-13. This is because of a bug in gcc-13 when evaluating concept-constrained partial specialisation of nested templates. Hence, the error: Error from CI: Code from codegen_internal.h(present in my changes): Since CI uses these older compilers, we may have a few options if we want to proceed:
- VisitArrayValuesInline<Arg0Type>(arg0, [&](Arg0Value v) {
- *out_data++ = functor.op.template Call<OutValue, Arg0Value>(ctx, v, &st);
+ VisitArrayValuesInline<Arg0Type>(arg0, [&](typename ThisType::Arg0Value v) {
+ *out_data++ = functor.op.template Call<typename ThisType::OutValue, typename ThisType::Arg0Value>(ctx, v, &st);
BTW, is there any reason why compilers are not being upgraded? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is a preliminary PR intended to demonstrate the scope and feasibility of modernizing the Arrow C++ codebase using C++20 Concepts.
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
Questions for the Reviewer