GH-41624: [C++] Add missing system Boost dependency to bundled Apache Thrift#49346
Merged
kou merged 1 commit intoapache:mainfrom Feb 20, 2026
Merged
GH-41624: [C++] Add missing system Boost dependency to bundled Apache Thrift#49346kou merged 1 commit intoapache:mainfrom
kou merged 1 commit intoapache:mainfrom
Conversation
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting committer review
wgtmac
approved these changes
Feb 20, 2026
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b7ed8df. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Some public headers in Apache Thrift depend on Boost. So our bundled Apache Thrift CMake target must depend on Boost. We set it for system Apache Thrift but doesn't for bundled Apache Thrift + system Boost.
What changes are included in this PR?
Boost::headersdependencies to bundled Apache Thrift even when we use system Boost.Boost::headersdependency fromPARQUET_TEST_LINK_LIBS.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.