GH-33241: [Archery] Replace github3 with pygithub#48886
GH-33241: [Archery] Replace github3 with pygithub#48886fangchenli wants to merge 5 commits intoapache:mainfrom
Conversation
|
|
|
|
fangchenli
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
Thanks for the PR, awesome work. The changes look great in general. I'll have to take some time to do some validation as crossbow isn't extensively tested at the moment. Can you remove this one while I find some time to test it?
arrow/ci/conda_env_archery.txt
Line 22 in 894d6a3
|
Failures are unrelated, will be fixed once the following issue closed. It has a PR ready to be merged: |
There was a problem hiding this comment.
Changes look good to me. Thanks @fangchenli
@kou I plan to merge this and if we find any small issue not covered by tests during crossbow runs we can fix them.
I haven't validated manually the different cases but have reviewed the changes.
2 participants
Rationale for this change
Archery currently uses both pygithub and github3. It's unnecessary and increases maintenance burden.
What changes are included in this PR?
Replace all github3 usage with pygithub.
Are these changes tested?
Yes, unittests added.
Are there any user-facing changes?
No.
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
No.
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
No.