GH-1116: [Java] Fix compressed buffer prefix write and ZSTD dstCapacity#1119
Open
LuciferYang wants to merge 1 commit intoapache:mainfrom
Open
GH-1116: [Java] Fix compressed buffer prefix write and ZSTD dstCapacity#1119LuciferYang wants to merge 1 commit intoapache:mainfrom
LuciferYang wants to merge 1 commit intoapache:mainfrom
Conversation
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes in the compression codec:
AbstractCompressionCodec.compress(): uncompressed-length prefix could be written with a wrong valueThe old code read
uncompressedBuffer.writerIndex()afterdoCompress()to populate the 8-byte prefix. ButuncompressedBufferis a shared reference to the vector's internal buffer. IfwriterIndexchanged betweendoCompress()and the subsequent read -- e.g. due toVectorSchemaRootreuse (clear/allocateNew) -- the prefix would get a wrong value such as 0.Fix: capture
writerIndex()once at the top ofcompress()and reuse it for the empty-buffer check, size comparison, and prefix write.ZstdCompressionCodec.doCompress():dstCapacityoverstated by 8 bytesZstd.compressUnsafe(dst, dstSize, ...)expectsdstSizeto be the available space fromdst. The code offsetsdstby 8 bytes past the prefix, but passed8 + maxSizeinstead ofmaxSize. In practicecompressBound()headroom prevented an actual out-of-bounds write, but the parameter was semantically wrong.Fix: pass
maxSizeinstead ofdstSize.Tests
testMultiBatchZstdStreamWithWideSchemaAndAllNulls-- 100 fields x 10 batches x 500 rows,VectorSchemaRootreuse with all-null timestamp columns in every 3rd batch, full streaming round-trip with per-cell verification.testAllNullFixedWidthVectorZstdRoundTrip-- 3469-row all-nullTimestampMilliVector, buffer-level compress/decompress, asserts decompressedwriterIndexmatches the original.Closes
Closes #1116