Conversation
eubnara
commented
Feb 26, 2025
| idsSubList.get(0) + " - " + idsSubList.get(idsSubList.size() - 1)); | ||
| requestScheduleQuery.setParameter("scheduleIds", idsSubList); | ||
| affectedRows += requestScheduleQuery.executeUpdate(); | ||
| LOG.info("Deleting RequestScheduleBatchRequest entity batch with schedule ids: " + |
Contributor
Author
There was a problem hiding this comment.
RequestSchedule is related to RequestScheduleBatchRequest.
I guess that RequestSchedule is usually removed with RequestScheduleBatchRequest.
@Override
public void delete() {
readWriteLock.writeLock().lock();
try {
if (isPersisted) {
batchRequestDAO.removeByScheduleId(requestScheduleEntity.getScheduleId());
requestScheduleDAO.remove(requestScheduleEntity);
cluster.refresh();
isPersisted = false;
}
} finally {
readWriteLock.writeLock().unlock();
}
}…RequestEntity also
eubnara
force-pushed
the
AMBARI-26312
branch
from
February 26, 2025 03:35
eab3c3a to
4eb474f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If some classes implements "Cleanable", CleanupDriver will call cleanup() for those classes when administrator uses "ambari-server db-purge-history".
"requestschedule" and "requestschedulebatchrequest" tables could be cleaned up with old rows.
How was this patch tested?
manual tests on my company's cluster.