Consume external role ARN in Neptune Analytics system test#69682
Open
seanghaeli wants to merge 2 commits into
Open
Consume external role ARN in Neptune Analytics system test#69682seanghaeli wants to merge 2 commits into
seanghaeli wants to merge 2 commits into
Conversation
The example_neptune_analytics system test previously created and deleted its own IAM role (create_neptune_import_role / delete_neptune_import_role) for Neptune Analytics to assume when reading the import data from S3. Per review feedback, system tests should not create IAM roles. The role is now provisioned externally (in the system-test infrastructure / CDK) and its ARN is fetched via SystemTestContextBuilder().add_variable( "NEPTUNE_IMPORT_ROLE_ARN") and passed to the NeptuneStartImportTaskOperator and NeptuneCreateGraphWithImportOperator. This removes the role-creation tasks, the associated trust/inline policy JSON, and the 60s IAM consistency sleep.
346e2f8 to
0ddc10c
Compare
vincbeck
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Neptune Analytics system test to import role from AWS test harness