Reduce DAG card tooltip controller overhead#69681
Open
shivaam wants to merge 2 commits into
Open
Conversation
shivaam
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card view requests up to 14 recent runs per DAG. The first 50 cards can therefore create up to 700 independent Chakra tooltip roots and state machines, even though only one tooltip per card can be active at a time.
Reuse one multi-trigger tooltip root per DAG card. Keep every recent-run bar visible and clickable, and resolve the selected run's existing tooltip details through
Tooltip.Contextwhen the user focuses or hovers a trigger.I tested it locally and it feels slightly faster.
No visual change is expected.
related: #69609
Testing:
pnpm exec vitest run src/pages/DagsList/DagCard.test.tsxpnpm exec tsc --p tsconfig.app.json --noEmitpnpm exec eslint src/pages/DagsList/RecentRuns.tsx src/pages/DagsList/DagCard.test.tsxpnpm builduvx prek run --files airflow-core/src/airflow/ui/src/pages/DagsList/RecentRuns.tsx airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.test.tsxWas generative AI tooling used to co-author this PR?
Generated-by: Codex following the guidelines
UI-fix1.mov