Flag conn-fields in hook but absent from provider.yaml in static checks#69655
Open
dabla wants to merge 2 commits into
Open
Flag conn-fields in hook but absent from provider.yaml in static checks#69655dabla wants to merge 2 commits into
dabla wants to merge 2 commits into
Conversation
d67b4c8 to
2107311
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
check_conn_fields_match_form_widgetsstatic check introduced in #69473only validated one direction: stale keys declared in
conn-fields(YAML) that nolonger exist in
get_connection_form_widgets(). It did not catch the oppositecase — a field added to the hook's form widgets but forgotten in
conn-fields—which means the field silently disappears from the new React connection UI.
PR #64643 (Samba
auth_protocol) exposed this gap:auth_protocolwas added toget_connection_form_widgets()but not toconn-fieldsinprovider.yaml, andthe check passed without complaint.
The fix makes the check bidirectional: when
conn-fieldsis declared, its keysmust exactly match the hook's widget keys. Both directions are now reported as
errors with distinct fix hints. The "no
conn-fieldsat all" case is stillsilently skipped (opting out of the React UI form is intentional).
Was generative AI tooling used to co-author this PR?
Claude Sonnet 4.6
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.