Fix TimeSensor start_from_trigger causing dag_version churn#69610
Open
bramhanandlingala wants to merge 1 commit into
Open
Fix TimeSensor start_from_trigger causing dag_version churn#69610bramhanandlingala wants to merge 1 commit into
bramhanandlingala wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #69543
TimeSensorcomputed its target time usingdatetime.now()at DAG-parsetime. When
start_from_trigger=True, this value got baked into theserialized DAG, causing the
dag_versionto change on every parse thatcrossed a day boundary.
This can't be fixed by computing the value differently, since the target
moment is inherently different each day but
start_trigger_argsis onlycomputed once per DAG version. So
start_from_trigger=Truenow raises aValueErrorinstead of silently producing a broken serialization.deferrable=Truestill works as before and is unaffected.Also fixed the docs, which incorrectly said the target time is evaluated
against
data_interval_end/run_after— it never was.Added a test for the new
ValueError; all existing tests still pass.