Show Dag Run conf column by default in Dag Runs list#68904
Conversation
There was a problem hiding this comment.
Thanks for the PR.
I'm fine with showing 'conf' column by default, but can you explain the motivation by replacing the monaco editor with a custom one and then a modal for monaco? (First it's inconsistent with how we display json content in the UI, and also it offers far less features, highlighting, expand/collapse etc...)
Maybe for performance reason (less monaco IDE mounted at once on the same page)? That still makes the content of the conf available through an extra click, and there are plenty of other tables with monaco columns (xcoms, assets, etc...) that currently work fine. If we want to change this, we probably need to change it for all tables and unless it's proven to be a performance bottleneck (with experiment and metrics) I wouldn't be in favor of going in that direction. Also if we want to explore it, I would create a separate PR because we probably want to discuss more about this and not block the 'display config column by default' part.
Also CI need fixing.
31cb329 to
3bf78bb
Compare
Thanks for the review, agreed on keeping Monaco inline for consistency with XCom/Assets/etc. I've dropped the custom preview/dialog (DagRunConfCell) and reverted to the existing RenderedJsonField collapsed cell. The PR now only makes the Conf column visible by default. Removed the newsfragment per your comment. Rebased onto the latest main to fix CI. |
d915492 to
ccc1704
Compare
Airflow 3 hid the conf column even though the API and column definition already existed. Operators triggering Dags with run conf need that context in the list view without toggling columns manually. closes: apache#53382
6b5148b to
7805859
Compare
|
@pierrejeambrun Thanks for the thorough review! All suggestions are addressed. Please take another look when you have a moment. |
|
Could you update the screenshots please? |
@bbovenzi I have updated the screenshots, can you please check? |
|
Thanks for the review. One follow-up idea I'd like your take on: show conf content expanded by default in the Dag Runs list (i.e. drop collapsed on the conf cell), rather than the folded { ... } preview users have to open row by row. (If I am not wrong, this case is there in AF2) Motivation: when I'm triaging or comparing runs, I often want to quickly scan or diff conf values across rows (env, batch id, feature flags, etc.). With the column visible but folded, I still have to expand each row manually, which doesn't help much for search/compare workflows. Trade-off I'm aware of: expanded JSON will make rows taller and the table noisier, especially for large conf objects — which is probably why XCom/Assets use collapsed previews in list views. Conf might be different, though: it's usually smaller and more often the thing you're looking at on this page. Questions: Do you think unfolded conf by default is reasonable on Dag Runs, or should we keep collapsed for consistency with other JSON columns? |
|
Looking better!
|
|
Makes sense to add expand/collapse like XCom. I'm working on a follow-up PR to add expand/collapse-all on the Dag Runs page. I'll tackle the Monaco collapsed preview ({...} instead of a useful preview) in a separate PR after that, as suggested. Will link the follow-up here once it's up. |
|
Follow-up is up in #69567 - expand/collapse-all on Dag Runs conf, with collapse/expand screenshots. Monaco preview improvement still planned as a separate PR. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
…che#68904) Airflow 3 hid the conf column even though the API and column definition already existed. Operators triggering Dags with run conf need that context in the list view without toggling columns manually. (cherry picked from commit 50c44b5) Co-authored-by: Ashutosh Shaha <61512480+ashutosh264@users.noreply.github.com> closes: apache#53382
…che#68904) Airflow 3 hid the conf column even though the API and column definition already existed. Operators triggering Dags with run conf need that context in the list view without toggling columns manually. (cherry picked from commit 50c44b5) Co-authored-by: Ashutosh Shaha <61512480+ashutosh264@users.noreply.github.com> closes: apache#53382
) (#69604) Airflow 3 hid the conf column even though the API and column definition already existed. Operators triggering Dags with run conf need that context in the list view without toggling columns manually. (cherry picked from commit 50c44b5) closes: #53382 Co-authored-by: Ashutosh Shaha <61512480+ashutosh264@users.noreply.github.com>
) (#69604) Airflow 3 hid the conf column even though the API and column definition already existed. Operators triggering Dags with run conf need that context in the list view without toggling columns manually. (cherry picked from commit 50c44b5) closes: #53382 Co-authored-by: Ashutosh Shaha <61512480+ashutosh264@users.noreply.github.com>


Airflow 3 already exposed Dag Run conf in the API and defined a Conf column in the Dag Runs table, but the column was hidden by default (
conf: falseincolumnVisibility). That broke AF2 parity for operators who trigger Dags with run conf and need to see it in the list without opening column settings.This PR makes the Conf column visible by default. Rendering is unchanged — the existing inline
RenderedJsonField(collapsed Monaco JSON), consistent with XCom, Assets, and other tables.Applies to both Browse → Dag Runs (
/dag_runs) and Dag → Runs (/dags/:dagId/runs).closes: #53382