[#1826] fix(test): Fix flakiness in AMQ4930Test#1825
Open
gurpartap3697 wants to merge 1 commit intoapache:mainfrom
Open
[#1826] fix(test): Fix flakiness in AMQ4930Test#1825gurpartap3697 wants to merge 1 commit intoapache:mainfrom
gurpartap3697 wants to merge 1 commit intoapache:mainfrom
Conversation
gurpartap3697
changed the title
gurpartap3697
force-pushed
the
fix/AMQ-4930-flaky-test
branch
from
af85ca0 to
0076999
Compare
jbonofre
reviewed
Mar 25, 2026
activemq-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ4930Test.java
Outdated
Show resolved
Hide resolved
activemq-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ4930Test.java
Outdated
Show resolved
Hide resolved
activemq-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ4930Test.java
Outdated
Show resolved
Hide resolved
gurpartap3697
force-pushed
the
fix/AMQ-4930-flaky-test
branch
from
0076999 to
286340b
Compare
jbonofre
approved these changes
Mar 25, 2026
Contributor
Author
|
Thanks for the feedback — updated the pr with suggested changes. |
Member
|
@gurpartap3697 I will merge as soon as CI is happy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the flakiness in AMQ4930Test.
Existing test relies on Runtime.freeMemory() and explicit gc() calls, which makes the test flaky due to JVM heap resizing and GC timing variability.