fix(tui): show background shell completion#36534
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Background shell completion now appears at the point where it wakes the parent session, using the same concise transcript language as background subagents.
Before
After
Long and multiline commands are normalized to one line and truncated from the right with a muted ellipsis instead of wrapping.
How
packages/core/src/tool/shell.tsadds the existing syntheticdescriptionfield and shell completion metadata to the durable notification already used to wake the parent.packages/tui/src/routes/session/index.tsxrecognizes shell completion metadata, rendersShell finished/failed/cancelled, and constrains the notice to one line.packages/tui/src/util/locale.tsperforms grapheme-safe, terminal-width-aware right truncation so the ellipsis retains the muted command styling.Scope
This does not change Job semantics, public schemas, Protocol or Server APIs, generated clients, database schemas, or shell execution behavior.
Job.completedcontinues to mean the background Effect produced its result, not that the command exited successfully.Testing
cd packages/core && bun run test test/tool-shell.test.tscd packages/core && bun typecheckcd packages/tui && bun run test test/util/locale.test.ts test/cli/tui/session-rows.test.ts test/cli/tui/inline-tool-wrap-snapshot.test.tsxcd packages/tui && bun typecheckgit diff --checkDemo
The deterministic OpenCode Drive run launches the real V2 TUI against the simulated backend, starts a real background shell command, shows the muted right-truncated completion notice, and then shows the parent response after wakeup.
recording-0a30171b-5831-490e-baf0-52fde7dbcdee.mp4
Flow