fix: wrap message-part-directory with LRE/PDF for RTL path display#36508
fix: wrap message-part-directory with LRE/PDF for RTL path display#36508tamish560 wants to merge 1 commit into
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #36488: Why it's related: This PR appears to address the same RTL bidi issue with message-part-directory using the same LRE/PDF unicode wrapping solution. Since the current PR (36508) mentions fixing "3 remaining" instances that were missed in PR #9591, PR #36488 may be an alternative or overlapping fix for the same problem. |
|
Closing this as #36488 by @windlandneko was opened first and covers the same fix (LRE/PDF wrapping in message-part.tsx for the same issue #36489). Didn't realize there was already a PR for this when I opened mine. Will watch for duplicates next time. |
What
Fixes the 3 remaining
message-part-directoryspans inmessage-part.tsxthat were not covered by PR #9591.Problem
CSS
direction: rtlon[data-slot="message-part-directory"](used for left-side ellipsis) causes the Unicode bidi algorithm to reposition leading dots in path names like.config/opencode/, rendering asconfig/opencode./.PR #9591 fixed this in
session-review.tsxandsession-turn.tsxby wrapping the directory text with...(LRE + PDF unicode marks). The same issue exists in 3 places inmessage-part.tsxthat were missed.Fix
Wrapped the 3 remaining
message-part-directoryspans with the same${getDirectory(...)}pattern:message-part-directorywithgetDirectory(props.input.filePath!)(2 instances)message-part-directorywithgetDirectory(single()!.relativePath)(1 instance)The
apply-patch-directoryspans in the same file already had this fix applied.Closes #36489