Skip to content

fix: wrap message-part-directory with LRE/PDF for RTL path display#36508

Closed
tamish560 wants to merge 1 commit into
anomalyco:devfrom
tamish560:fix/rtl-directory-paths
Closed

fix: wrap message-part-directory with LRE/PDF for RTL path display#36508
tamish560 wants to merge 1 commit into
anomalyco:devfrom
tamish560:fix/rtl-directory-paths

Conversation

@tamish560

Copy link
Copy Markdown

What

Fixes the 3 remaining message-part-directory spans in message-part.tsx that were not covered by PR #9591.

Problem

CSS direction: rtl on [data-slot="message-part-directory"] (used for left-side ellipsis) causes the Unicode bidi algorithm to reposition leading dots in path names like .config/opencode/, rendering as config/opencode./.

PR #9591 fixed this in session-review.tsx and session-turn.tsx by wrapping the directory text with ‪...‬ (LRE + PDF unicode marks). The same issue exists in 3 places in message-part.tsx that were missed.

Fix

Wrapped the 3 remaining message-part-directory spans with the same ‪${getDirectory(...)}‬ pattern:

  1. message-part-directory with getDirectory(props.input.filePath!) (2 instances)
  2. message-part-directory with getDirectory(single()!.relativePath) (1 instance)

The apply-patch-directory spans in the same file already had this fix applied.

Closes #36489

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Jul 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate Found

PR #36488: fix(session-ui): escape direction:rtl bidi issue in message-part-directory via LRE/PDF wraps
#36488

Why it's related: This PR appears to address the same RTL bidi issue with message-part-directory using the same LRE/PDF unicode wrapping solution. Since the current PR (36508) mentions fixing "3 remaining" instances that were missed in PR #9591, PR #36488 may be an alternative or overlapping fix for the same problem.

@tamish560

Copy link
Copy Markdown
Author

Closing this as #36488 by @windlandneko was opened first and covers the same fix (LRE/PDF wrapping in message-part.tsx for the same issue #36489). Didn't realize there was already a PR for this when I opened mine. Will watch for duplicates next time.

@tamish560 tamish560 closed this Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:compliance This means the issue will auto-close after 2 hours.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

direction:rtl reorders leading dot in directory paths (.config → config.)

1 participant