Fix overlapping subtitles with negative line numbers

[johnpc]

Summary

Fixes overlapping subtitle rendering when multiple WebVTT cues have overlapping timestamps and are assigned negative line numbers.

Problem

When multiple WebVTT cues overlap in time, WebvttSubtitle.getCues() correctly assigns them negative line numbers (-1, -2, -3, etc.) to stack them from the bottom. However, SubtitlePainter calculates each cue's vertical position using only firstLineHeight (the height of a single text line), not accounting for the actual multi-line height of preceding cues.

This causes cues to visually overlap when:

1. Multiple cues are displayed simultaneously
2. Any of the cues wrap to multiple lines

This is particularly common in anime subtitles where overlapping timestamps are used for effects like showing both dialogue and on-screen text.

Solution

1. Added getLastDrawnTextHeight() to SubtitlePainter to expose the actual rendered height of a text cue
2. Modified CanvasSubtitleOutput.dispatchDraw() to track cumulative height of bottom-stacked cues (those with negative LINE_TYPE_NUMBER) and adjust the drawing boundary for subsequent cues

Testing

Added unit tests for:

• SubtitlePainterTest: Tests for getLastDrawnTextHeight() with various cue types
• CanvasSubtitleOutputTest: Tests for rendering overlapping cues without visual overlap

Fixes #2237

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[icbaker]

Thanks for the PR - is there a reason you are specifically handling negative line numbers? I think the same problem can occur with positive line numbers too.

Would you be able to handle the positive line numbers case in this PR as well? I think a list of cues could have cues with both positive & negative line numbers (some at the top, some at the bottom of the screen, at the same time) - so handling both cases separately would probably be best. I think it makes sense to handle both cases at the same time so that we don't accidentally over-fit the solution to only one of the two cases.

Please also rebase the PR to target the main branch as that's where we merge contributions.

[johnpc]

@icbaker I've addressed all your feedback - updated copyright years, renamed the method to getLastDrawnTextBottom() with clearer docs, added support for positive line numbers, and rebased onto main. Ready for another look when you have time!

[johnpc]

Gentle ping on this, not sure what review timeline expectations there are for external contributions. Just want to make sure it's on your radar!

[johnpc]

I've tested this by building into the jellyfin-androidtv app and confirming that it fixes my original subtitle issue jellyfin/jellyfin-androidtv#4522

It does work.

Worth noting that in my case, the subtitles are still out-of-order, but I think that's fine since it's sort of undefined behavior in an srt anyway, and it matches what happens in jellyfin-web