[Enhance] Prioritize node created from assets#222
Open
Looooong wants to merge 1 commit into
Open
Conversation
Looooong
force-pushed
the
enhance/prioritize-node-created-from-assets
branch
from
September 26, 2022 16:45
76cd680 to
8f8b1f1
Compare
dyonng
added a commit
to dyonng/NodeGraphProcessor
that referenced
this pull request
Jul 24, 2026
- Make BaseGraphView.CanConnectEdge virtual (upstream alelievr#232), so subclasses can override edge-connection validation without forking. - Change nodeTypePerCreateAssetType to a SortedDictionary with a subclass-priority comparer (upstream alelievr#222), so dragging an asset whose type has multiple matching ICreateNodeFrom<T> implementations picks the most derived one instead of an arbitrary insertion-order match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, when drag&dropping asset into a graph, the node that implements
ICreateNodeFrom<CustomRenderTexture>should be prioritized over the node that implementsICreateNodeFrom<Texture>, becauseCustomRenderTextureis the subclass ofTexture.BaseGraphView.nodeTypePerCreateAssetTypeis changed fromDictionarytoSortedDictionaryto support this behaviour.