Skip to content

fix(app): use module names in BlockedAddrs#2043

Merged
troian merged 1 commit intomainfrom
app
Feb 27, 2026
Merged

fix(app): use module names in BlockedAddrs#2043
troian merged 1 commit intomainfrom
app

Conversation

@troian
Copy link
Member

@troian troian commented Feb 27, 2026

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Signed-off-by: Artur Troian <troian@users.noreply.github.com>
@troian troian requested a review from a team as a code owner February 27, 2026 00:35
@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 233a522 and 7fd976e.

📒 Files selected for processing (1)
  • app/app.go

Walkthrough

The BlockedAddrs function in app/app.go has been refactored to use ModuleAccountPerms() instead of ModuleAccountAddrs(), with the loop iteration variable renamed from acc to macc to better reflect module account handling.

Changes

Cohort / File(s) Summary
Module Account Permissions Refactor
app/app.go, go.mod
Updated BlockedAddrs to call ModuleAccountPerms() instead of ModuleAccountAddrs(); renamed iteration variable from acc to macc for clarity; adjusted module address lookup and map indexing accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 From Addrs to Perms our function hops,
Variable names get a fresh rebrand,
With macc in hand, the logic never stops,
A tidier module account in our land! 🌱

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description references a template for fix-type PRs and includes a checklist, but lacks specific details about the actual changes made to BlockedAddrs. Add details about what was changed in BlockedAddrs and why ModuleAccountPerms() replaces ModuleAccountAddrs(), and fill in the actual issue number being closed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: using module names instead of addresses in the BlockedAddrs function, which aligns with the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch app

Comment @coderabbitai help to get the list of available commands and usage tips.

@troian troian merged commit 5203a52 into main Feb 27, 2026
18 checks passed
@troian troian deleted the app branch February 27, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant