feat(inkless): POD-2457 Allow transactional offset commits for Diskless sources#596
Open
AnatolyPopov wants to merge 1 commit into
Open
feat(inkless): POD-2457 Allow transactional offset commits for Diskless sources#596AnatolyPopov wants to merge 1 commit into
AnatolyPopov wants to merge 1 commit into
Conversation
…ss sources Permit TxnOffsetCommitRequest to reference Diskless topic-partitions as offset keys, enabling transactional offset commits for consumers reading from Diskless topics.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables transactional offset commits for consumers reading from Diskless topics by allowing TxnOffsetCommitRequest to use Diskless topic-partitions as offset keys, while keeping transactional production to Diskless topics unsupported.
Changes:
- Removes the Kafka API rejection of Diskless topics in transactional offset commit requests.
- Updates unit and integration tests to cover successful transactional offset commits for Diskless sources.
- Updates Inkless feature documentation to distinguish transactional offset commits from unsupported transactional production paths.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
core/src/main/scala/kafka/server/KafkaApis.scala |
Allows validated Diskless topic partitions to flow to the group coordinator for transactional offset commits. |
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala |
Updates the Diskless transactional offset commit unit test to expect success and verify coordinator delegation. |
core/src/test/java/kafka/server/InklessLegacyClusterTest.java |
Adds an end-to-end legacy cluster test for sendOffsetsToTransaction with a Diskless source topic. |
docs/inkless/FEATURES.md |
Documents transactional offset commits as supported and clarifies remaining unsupported transactional operations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Do you have some broader context here? Why can we allow transactional offset commits? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permit TxnOffsetCommitRequest to reference Diskless topic-partitions as offset keys, enabling transactional offset commits for consumers reading from Diskless topics.