feat(inkless:test): implement system test for classic to diskless migration#581
Draft
giuseppelillo wants to merge 13 commits into
Draft
feat(inkless:test): implement system test for classic to diskless migration#581giuseppelillo wants to merge 13 commits into
giuseppelillo wants to merge 13 commits into
Conversation
giuseppelillo
commented
Apr 27, 2026
Comment on lines
+298
to
+303
|
|
||
| - name: software.amazon.awssdk | ||
| level: WARN | ||
|
|
||
| - name: io.netty | ||
| level: WARN |
Contributor
Author
There was a problem hiding this comment.
Avoid overfilling logs with S3 debug logs
giuseppelillo
commented
Apr 27, 2026
Comment on lines
+103
to
+111
| def supports_command_config(self): | ||
| return self >= V_4_2_0 | ||
|
|
||
| def supports_formatter_property(self): | ||
| return self >= V_4_2_0 | ||
|
|
||
| def supports_command_property(self): | ||
| return self >= V_4_2_0 | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Needed to run tests, align with upstream: https://github.com/apache/kafka/blob/trunk/tests/kafkatest/version.py
giuseppelillo
force-pushed
the
giuseppelillo/diskless-migration-system-test
branch
3 times, most recently
from
9027a20 to
5de7cf2
Compare
EelisK
reviewed
May 7, 2026
giuseppelillo
force-pushed
the
giuseppelillo/diskless-migration-system-test
branch
from
5de7cf2 to
ee8517b
Compare
giuseppelillo
force-pushed
the
giuseppelillo/diskless-migration-system-test
branch
from
8ec2d9d to
716e962
Compare
giuseppelillo
commented
May 27, 2026
Comment on lines
+2468
to
+2471
|
|
||
| systemTestLibs { | ||
| dependsOn testJar | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Necessary to pack jars for tiered storage tests
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Inkless system test suite to exercise classic-to-diskless (and classic+tiered-to-diskless) topic migration paths under normal operation and injected faults, plus supporting test harness/build tweaks needed to run these scenarios in ducktape.
Changes:
- Introduce
InklessTopicMigrationTestwith migration validation scenarios (post-migration availability, mid-migration fault tolerance via Trogdor, and operational/concurrent cases). - Extend
KafkaServicewith helper methods to alter/describe topic configs viakafka-configs.sh. - Update test infra: add Kafka 4.2 version flags, quiet noisy AWS/Netty logs in system tests, and ensure
:storagetest JAR is built as part ofsystemTestLibs.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/kafkatest/version.py | Add Kafka 4.2 version constants and feature-flag helpers used by CLI wrappers. |
| tests/kafkatest/tests/inkless/inkless_topic_migration_test.py | New end-to-end system tests for classic→diskless migration (including tiered storage and fault injection). |
| tests/kafkatest/services/kafka/templates/log4j2.yaml | Reduce AWS SDK and Netty log noise in Log4j2-based broker/test logs. |
| tests/kafkatest/services/kafka/templates/log4j.properties | Reduce AWS SDK and Netty log noise in Log4j1-based broker/test logs. |
| tests/kafkatest/services/kafka/kafka.py | Add alter_topic_config and describe_topic_config helpers used by the migration tests. |
| build.gradle | Make :storage:systemTestLibs depend on testJar so the storage test JAR is produced for system tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
giuseppelillo
force-pushed
the
giuseppelillo/diskless-migration-system-test
branch
from
716e962 to
c8d42ce
Compare
LocalTieredStorage lives in storage/src/test/java and is needed on the broker classpath by InklessTopicMigrationTest's tiered-to-diskless migration test. Wire `testJar` into `:storage`'s `systemTestLibs` so `./gradlew systemTestLibs` produces kafka-storage-*-test.jar.
giuseppelillo
force-pushed
the
giuseppelillo/diskless-migration-system-test
branch
from
8676d3b to
28f4bd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.