tests: Add Fleet and FleetAutoscaler tests#27
Open
NAME-ASHWANIYADAV wants to merge 6 commits into
Open
Conversation
Signed-off-by: ashwani yadav <22ashwaniyadav@gmail.com>
Signed-off-by: ashwani yadav <22ashwaniyadav@gmail.com>
Signed-off-by: ashwani yadav <22ashwaniyadav@gmail.com>
NAME-ASHWANIYADAV
marked this pull request as draft
June 23, 2026 23:18
Member
|
oh fun more conflicts ohno 😄 |
Contributor
Author
|
@markmandel I resolved the conflict , will appreciate a re-reviw!! |
NAME-ASHWANIYADAV
marked this pull request as ready for review
July 16, 2026 21:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What this PR does
Adds comprehensive unit tests for the
FleetandFleetAutoscalerresource models using the Vitest infrastructure introduced in #26.Fleet tests (30 tests):
scheduling,desiredReplicas,currentReplicas,allocatedReplicas,readyReplicas,reservedReplicas,strategy,maxSurge,maxUnavailable,allocationOverflow,priorities,counters,lists.FleetAutoscaler tests (34 tests):
fleetName,policyType,bufferSize,minReplicas,maxReplicas,currentReplicas,desiredReplicas,ableToScale,scalingLimited,lastScaleTime,lastAppliedPolicy,syncInterval.Did you use AI tools in preparing this PR?:
Y
Test plan
Automated checks
npm cinpm run buildnpm run tscnpm run lintnpm run format -- --checknpm run testAll 121 tests pass across 5 test files (GameServer 29, Fleet 30, FleetAutoscaler 34, StateChip 13, buildAllocationBody 15).
Manual verification
N/A - unit tests only.
Notes for reviewers
All test data structures are verified against the upstream Agones Go structs (
fleet.go,fleetautoscaler.goinagones-upstream/pkg/apis/agones/v1/).