Include more information for file edits#126
Draft
SteffenDE wants to merge 2 commits intoagentclientprotocol:mainfrom
Draft
Include more information for file edits#126SteffenDE wants to merge 2 commits intoagentclientprotocol:mainfrom
SteffenDE wants to merge 2 commits intoagentclientprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, edits are only reported as "Editing files" without any details. This PR tries to add diffs for edits, as well as including the raw diff in rawOutput.
I also stumbled across another issue, which I included as part of a separate commit, but which is worth discussing: when Codex requests permissions because the sandbox failed, the permission request contains content. In Tidewave, we merge tool call updates, but we don't append content, so if Codex sends a permission request, the previous diff content would be overwritten by it. I'm wondering if Codex should report the reason in a custom
_metafield instead. This PR just omits the reason in permission requests for now.Codex wrote the code, so there may be better ways to do this.