Conversation
Collaborator
|
I’m not sure we really need the mocked gateway and request assertions here. I'd suggest implementing a simple ACP Client instead; we could use the API key and base URL to handle actual gateway authentication for a basic prompt. My thought is to prioritize E2E tests using that client—keeping mocks to a minimum so we can cover the longest execution paths first. What do you think? |
AlexandrSuhinin
approved these changes
Apr 27, 2026
Collaborator
AlexandrSuhinin
left a comment
AlexandrSuhinin
left a comment
There was a problem hiding this comment.
But I'm not against merging these tests.
1. Extract abstractions from acp-e2e-test-utils.ts 2. Get rid of SpawnedSessionFixture, keeping SpawnedAgentFixture only 3. General cleanup and members re-ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.