Conversation
AlexandrSuhinin
requested changes
Apr 28, 2026
| supportedReasoningEfforts: currentModel?.supportedReasoningEfforts ?? [], | ||
| supportedInputModalities: currentModel?.inputModalities ?? ["text", "image"], | ||
| agentMode: AgentMode.getInitialAgentMode(), | ||
| pendingTurnId: null, |
Collaborator
There was a problem hiding this comment.
Can single session have two active turns? Can we reuse currentTurnId here?
Advertise ACP close capability and implement `unstable_closeSession` to interrupt active turns, unsubscribe threads, remove per-session listeners, and forget session state.
Store pending turn ids separately from turn completion so session shutdown can interrupt only active turns and wait for them to finish. Also scope app-server notifications to their thread and avoid sending command/session updates after a session has been removed or is closing.
benbrandt
force-pushed
the
session-close
branch
from
fbfb2c4 to
deb1946
Compare
benbrandt
force-pushed
the
session-close
branch
from
22f5a21 to
b46d043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably needs a close look as it ended up needing to touch more than I expected