e2e/networking: retry ingress request until xDS routes are ready - #724
Open
Aditya Shantanu (aditya-shantanu) wants to merge 1 commit into
Open
Conversation
TestActorDirectAccess/via_ingress was flaky because the test probed the ingress immediately after ResumeActor returned, before the Envoy xDS update from the control plane had propagated — causing intermittent 503 connection timeouts. Retry the GET with a 30 s deadline (1 s intervals), the same pattern used by waitForActorStatus and callActor elsewhere in the e2e suite. Fixes agent-substrate#723.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestActorDirectAccess/via_ingresswas intermittently failing with HTTP 503 / connection timeout because the test sent a single request immediately afterResumeActorreturned, before the Envoy xDS update had propagated to the router.waitForActorStatusandcallActorelsewhere in the e2e suite.defer response.Body.Close()was called beforeio.ReadAll, but the body was read correctly — the retry loop now closes each response body explicitly per iteration.Fixes #723.
Test plan
e2e-test (cert)ande2e-test (token)pass —TestActorDirectAccess/via_ingressno longer fails on slow xDS propagation"Actor access through ingress succeeded"as before