Skip to content

Back cdr : Endpoint to get total of validated payments - #1028

Merged
Bombefire merged 35 commits into
mainfrom
total-purchase
Sep 15, 2026
Merged

Bombefire merged 35 commits into
mainfrom
total-purchase

Conversation

@Bombefire

Copy link
Copy Markdown
Contributor

Description

Summary

Adding the endpoint for Enceladus to have the total payment done in the CDR and have the total of purchase that have been validated by the sellers.

...

Issues/PR dependencies

A futur PR in Enceladus will come to make use of this endepoint

Issues to be resolved

Required PRs

Changes Made

  • ...
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.96%. Comparing base (e1f6c81) to head (019bb3c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
+ Coverage   84.94%   84.96%   +0.02%     
==========================================
  Files         220      220              
  Lines       16378    16400      +22     
==========================================
+ Hits        13912    13934      +22     
  Misses       2466     2466              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread app/modules/cdr/cruds_cdr.py
Comment thread app/modules/cdr/cruds_cdr.py Outdated
Comment thread app/modules/cdr/cruds_cdr.py Outdated
Comment thread app/modules/cdr/cruds_cdr.py Outdated
Comment thread app/modules/cdr/cruds_cdr.py Outdated
Comment thread app/modules/cdr/endpoints_cdr.py Outdated
Comment thread app/modules/cdr/endpoints_cdr.py Outdated
Comment thread app/modules/cdr/endpoints_cdr.py Outdated
Comment thread app/modules/cdr/endpoints_cdr.py Outdated
Comment thread app/modules/cdr/endpoints_cdr.py Outdated
Comment thread app/modules/cdr/cruds_cdr.py Outdated
Comment thread app/modules/cdr/endpoints_cdr.py Outdated
Comment thread app/modules/cdr/endpoints_cdr.py Outdated
Comment thread app/modules/cdr/endpoints_cdr.py Outdated

@armanddidierjean armanddidierjean left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

Comment thread app/modules/cdr/cruds_cdr.py
Comment thread tests/modules/cdr/test_cdr.py Outdated
@Bombefire
Bombefire dismissed armanddidierjean’s stale review September 8, 2026 16:44

Implemented. How do you accept a change without dismissing it ?

@Bombefire
Bombefire requested a review from Rotheem September 8, 2026 16:59
Comment thread tests/modules/cdr/test_cdr.py Outdated
Comment thread tests/modules/cdr/test_cdr.py Outdated
Comment thread app/modules/cdr/endpoints_cdr.py Outdated

@armanddidierjean armanddidierjean left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bombefire
Bombefire merged commit 53e5e7e into main Sep 15, 2026
7 checks passed
@Bombefire
Bombefire deleted the total-purchase branch September 15, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants