Fix: restore inline styles in SharedElement cleanup to prevent stale … - #10617
Open
shehbaz-mustafa wants to merge 1 commit into
Open
shehbaz-mustafa wants to merge 1 commit into
shehbaz-mustafa wants to merge 1 commit into
Conversation
…offset under StrictMode + SSR hydration
snowystinger
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR
please reduce the comments, they are overly verbose
can you provide a test, this should be possible using fake timers
please clean up the title and description along with the issue this closes so they are linked
It looks like you're failing lint and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…offset under StrictMode + SSR hydration
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: