fix: return 405 for unsupported MCP methods - #398
Open
Ricky-7-Yan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
405 Method Not AllowedwithAllow: POSTwhen an MCP transport client sends GET or DELETE to the Streamable HTTP endpoint/mcpdashboard deep link for browser requests that prefer HTMLThis addresses the MCP routing finding in #389. The separate catalog placeholder/tool-hint finding is intentionally out of scope.
Validation
BUNDLE_GEMFILE=gemfiles/rails8.gemfile bundle exec ruby -Itest actionagent/test/engine_integration_test.rb(36 runs, 180 assertions)bundle exec rubocop actionagent/config/routes.rb actionagent/test/engine_integration_test.rb