Repository navigation
Update dependencies - #746
Merged
Merged
Conversation
Bump rails/railties to 7.2.4 in gemfiles/rails_72. activesupport 7.2.4 caps connection_pool below 3 because connection_pool 3.0 switched to keyword arguments, which breaks the ActiveSupport cache stores on Rails 7.2 (rails/rails#56291). Rails fixed the stores on 8.x and pinned connection_pool below 3 on 7-2-stable (rails/rails#56620), so add the same pin and a Dependabot ignore in the Rails 7.2 Gemfile. Without it, bundle update --all keeps the stale rails 7.2.3.2 + connection_pool 3.0.2 combination instead of reaching 7.2.4.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 17 17
Lines 459 459
=======================================
Hits 433 433
Misses 26 26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
rails/railtiesto 7.2.4 ingemfiles/rails_72and pinconnection_poolbelow 3.activesupport7.2.4 capsconnection_poolbelow 3 because connection_pool 3.0 switchedConnectionPool/ConnectionPool::TimedStackto keyword arguments, which breaks the ActiveSupport cache stores on Rails 7.2 (rails/rails#56291). The stores were fixed on 8.x, and since Rails 7.2 is security-only, Rails pinnedconnection_poolon7-2-stableinstead (rails/rails#56620).Without the explicit pin,
bundle update --allkeeps the stalerails 7.2.3.2+connection_pool 3.0.2combination and never reaches 7.2.4. The pin and the Dependabotignorefollow the existingparallelpin.Verification
bin/bundle update --allon Ruby 3.2.11 (the minimum tested by CI).BUNDLE_GEMFILE=gemfiles/rails_72/Gemfile bundle exec rspec— 140 examples, 0 failures.The update was produced automatically by AI.