Skip to content

[conflict_resolver] Add db translations for Conflict Resolver module#10846

Open
HachemJ wants to merge 4 commits into
aces:29.0-releasefrom
HachemJ:AddMissingDbTranslationsConflictResolver
Open

[conflict_resolver] Add db translations for Conflict Resolver module#10846
HachemJ wants to merge 4 commits into
aces:29.0-releasefrom
HachemJ:AddMissingDbTranslationsConflictResolver

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR adds missing db translations for the conflict resolver module. It affects filters dropdowns as well as the content of the table

Testing instructions (if applicable)

  1. delete project/locale
  2. copy raisinbread/locale into project/locale
  3. run make dev (make sure it ran the msgfmt --use-fuzzy -o table.mo table.po commands)
  4. Go to 'Clinical' -> 'Conflict Resolver'
  5. Switch the language to either 'French', 'Hindi' or 'Japanese' (the raisinbread locale languages so far)

For each tab (Unresolved and Resolved) :
6. Verify that every filter dropdown is translated in the language selected (I counted 5)
7. Verify that the content of the table (the rows) are translated in the language selected (Project, Cohort, Site, Visit Labels, Question columns)

Note: I used AI for hindi and japanese translations.

Link(s) to related issue(s)

@github-actions github-actions Bot added RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Language: PHP PR or issue that update PHP code Module: conflict_resolver PR or issue related to conflict_resolver module Multilingual Any tasks related to making LORIS multilingual labels Jul 8, 2026
@HachemJ HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 8, 2026
@HachemJ HachemJ changed the title [conflict_resolver] Adding db translations for Conflict Resolver module [conflict_resolver] Add db translations for Conflict Resolver module Jul 8, 2026
@CamilleBeau
CamilleBeau requested a review from skarya22 July 13, 2026 19:42
msgstr ""

msgid "weight_lbs"
msgstr ""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it would be good in the long run to need all instrument fields translated in the conflicts_resolved and unresolved tables... This would mean that projects with lots of instruments would have to update these files whenever a change to an instrument is made.

I think for now, since the official instrument field translations hasn't been done, let's remove the instrument field name translations for now from the PR

@skarya22 skarya22 added the State: Needs work PR awaiting additional work by the author to proceed label Jul 15, 2026
@skarya22 skarya22 assigned HachemJ and unassigned skarya22 Jul 15, 2026
@HachemJ HachemJ removed the State: Needs work PR awaiting additional work by the author to proceed label Jul 15, 2026
@HachemJ HachemJ assigned skarya22 and unassigned HachemJ Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: PHP PR or issue that update PHP code Module: conflict_resolver PR or issue related to conflict_resolver module Multilingual Any tasks related to making LORIS multilingual RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants