Fix unintended auto-selection in multiselect filters#10834
Open
HachemJ wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR fixes an auto-selection issue affecting pages with multiselect filters that contain only one option. This filter is automatically selected when the page is first loaded, even though no selection was made by the user. The current workaround is to click “Clear Filters” each time the page is opened.
This change disables the auto selection by overriding the autoSelect field to
autoSelect={false}because by default it's true.Testing instructions (if applicable)
One of the pages affected by this issue that I caught on the 29.0-release branch:
Link(s) to related issue(s)