feat: delete merit except claiming functionality#3068
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Nine Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
AGMASO
changed the title
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Eight Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Eight Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
3 participants
Summary
Removes the (now-defunct) Merit informational / APR display system from the interface. Merit no longer publishes new campaigns, so all the code that fetched and rendered Merit APRs/APYs and tooltips is dead. Claiming is intentionally kept — it's a separate flow (via the
@aave/reactSDK) so users can still claim previously-accrued Merit rewards.General Changes
useUserMeritRewardsfrom@aave/react, on-chain) and is preserved so users can still claim their old Merit rewards.0, since this asset will not receive rewards again.reserve-overview/Gho/SavingsGho.tsx) surfaced during cleanup.What was removed
Deleted files
src/hooks/useMeritIncentives.ts(MERIT_DATA_MAP, MeritAction, aavechan API fetch)src/hooks/useUserMeritIncentives.tssrc/hooks/useStakeTokenAPR.tssrc/components/incentives/MeritIncentivesTooltipContent.tsxsrc/modules/reserve-overview/graphs/MeritApyGraphExample.tsx(unused)src/modules/reserve-overview/Gho/SavingsGho.tsx(dead code — only referenced from a commented import)Edited (Merit removed, component kept)
IncentivesButton.tsx— removedMeritIncentivesButtonIncentivesCard.tsx/IncentivesTooltipContent.tsx— Merit dropped from the Total/Net APY math (nowprotocol ± protocolIncentives ± merkl)useUserYield.ts/useEnhancedUserYield.ts— Merit no longer added to Net APYStkGhoDepositRow.tsx,StkGhoSavingsRate.tsx,SavingsGhoModalDepositContent.tsx,GhoStakingPanel.tsx,StakingPanelNoWallet.tsx— APR/APY hardcoded to0GhoReserveConfiguration.tsx— removed commented references to the deleted componentWhat was intentionally kept
ClaimRewards/*,DashboardTopPanel,useUserMeritRewards(SDK). Untouched.MeritApyGraph*+useSGhoApyHistory+SGhoServiceread TokenLogic'saaveV3RatesSgho(the sGHO rate). The "Merit" naming is legacy only; this data source is alive and unrelated to the removed system.TokenList.ts— unrelated asset (MC).Investigate whether the stkGHO APY history graph is displaying the correct data. Even though the current stkGHO APY has dropped to 0%, the average shown in the graph remains unchanged at 3.26%.
We need to verify whether the data coming from TokenLogic is correct and whether the average APY is being calculated and displayed properly.
Testing
tsc --noEmit→ 0 errorseslinton all touched files → 0 errors+/ borrow−) preserveduseUserMeritRewardsandClaimRewards/*verified intact)