Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Uh oh!

There was an error while loading. Please reload this page.

WordPress / wordpress-develop Public

Notifications You must be signed in to change notification settings
Fork 3.6k
Star 3.4k

Code
Pull requests 3.2k
Actions
Security and quality 29
Insights

Additional navigation options

Code
Pull requests
Actions
Security and quality
Insights

Code Quality: Improve type specificity for comments#12606

Closed

westonruter wants to merge 23 commits into

WordPress:trunkWordPress/wordpress-develop:trunkfrom

westonruter:update/comment-typeswestonruter/wordpress-develop:update/comment-typesCopy head branch name to clipboard

Conversation Commits23 (23)Checks Files changed

Closed

Code Quality: Improve type specificity for comments#12606
westonruter wants to merge 23 commits into
WordPress:trunkfrom
westonruter:update/comment-types

Commits

Commits on Jul 20, 2026

Improve typing for comments

westonruter
and
claude
committed
Rename CommentArray to Data_Array
westonruter
committed
Add conditional return type to get_approved_comments()

westonruter
and
claude
committed
Correct comment array key types and narrow comment ID types

westonruter
and
claude
committed
Document comment status and type values, narrow comment_approved

westonruter
and
claude
committed
Define post_fields as list<non-empty-string>
westonruter
committed
Provide narrower non-PHPStan types
westonruter
committed
Add native return types
westonruter
committed
Provide enum type for $output param
westonruter
committed
Guard against fatal error in WP_Comment magic getter when underlying post is gone
westonruter
committed
Declare the post fields proxied by WP_Comment::__get()

westonruter
and
claude
committed
Restore non-array return modes of WP_Comment::get_children()

westonruter
and
claude
committed
Infer the count and ids return types of WP_Comment::get_children()

westonruter
and
claude
committed
Resolve the ids return type of WP_Comment::get_children() exactly

westonruter
and
claude
committed
Infer the cached children type in WP_Comment::get_children()

westonruter
and
claude
committed
Narrow the WP_Comment_Query result properties

westonruter
and
claude
committed
Merge branch 'trunk' into update/comment-types
westonruter
committed
Merge branch 'trunk' into update/comment-types
westonruter
committed
Improve consistentcy of conditional return formatting
westonruter
committed

Commits on Jul 21, 2026

Guard WP_Comment::__get() against unattached comments

westonruter
and
claude
committed
Narrow ARRAY_N return of get_comment() to non-empty-list

westonruter
and
claude
committed
Add @since entries for behavior changes in get_children() and get_comment()

westonruter
and
claude
committed
Add regression tests for comment runtime behavior changes

westonruter
and
claude
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.