Skip to content

Twenty Twenty-Five: Fix navigation contrast in header inside full-width background image pattern#11953

Open
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65323
Open

Twenty Twenty-Five: Fix navigation contrast in header inside full-width background image pattern#11953
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65323

Conversation

@itzmekhokan
Copy link
Copy Markdown

Summary

  • Adds a bundled header-inside-full-width-background-image pattern to Twenty Twenty-Five.
  • Gives the navigation block its own overlay colors (overlayBackgroundColor: base, overlayTextColor: contrast) so submenus and the mobile menu overlay remain readable when the main navigation uses white text on a dark background.

Problem

The Pattern Directory version sets textColor: white on the navigation block but does not set overlay colors. Core navigation CSS gives submenus a white background while text inherits white from the parent, producing invisible submenu items and an invisible mobile overlay.

Solution

Per core committer feedback, the navigation block needs its own coloring via block attributes — matching other Twenty Twenty-Five header patterns. No theme CSS overrides are needed; core navigation handles overlay/submenu colors when these attributes are present.

Trac ticket: https://core.trac.wordpress.org/ticket/65323

…th background image pattern.

Give the navigation block its own overlay colors so submenus and the mobile
menu overlay remain readable when used on a dark background with light text.

Fixes #65323.
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant