fix: add wp_supports_ai() and related constant + filter#11149
fix: add wp_supports_ai() and related constant + filter#11149justlevine wants to merge 7 commits intoWordPress:trunkfrom
wp_supports_ai() and related constant + filter#11149Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
justlevine
left a comment
There was a problem hiding this comment.
I'm not seeing a good way to repurpose the wp_ai_client_prevent_prompt since that hook seems to pass an instance of the *_Prompt_Builder which we don't have in all contexts (nor should we). Conceptually, disabling AI functionality entirely is higher up than preventing prompt-level execution, so making the builder instance arg nullable just to reuse the filter seems like a bad idea to me.
Same with implementing the wp_supports_ai() function into the class. We want to set the ::$error as early as possible, and not let wp_ai_client_prevent_prompt override the constant nor even run the filter callback if we already know we don't need to.
cc: @felixarntz in case you have some other ideas.
tests/phpunit/tests/connectors/wpConnectorsGetConnectorSettings.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Weston Ruter <westonruter@gmail.com>
This PR adds a
wp_supports_ai()function, alongside aWP_AI_SUPPORTconstant, andwp_supports_aifilter.When false,
_wp_connectors_get_provider_settings()will return an empty array (shortcircuiting the other functionality)WP_AI_Client_Prompt_Builder() will short-circuit the construction with aWP_Error()(wp_ai_client_prompt()` will still return an instance, to allow for fluidity to remain intact.Priority:
WP_AI_SUPPORT> add_filter( 'wp_supports_ai', ...) > (default: true)`Not Included
Using
wp_supports_ai()to gate the loading of wp-ai-client or php-ai-client classes. This is to maintain the current usage for developers, and not require folks to rewrite their compatibility yet again.Trac ticket: https://core.trac.wordpress.org/ticket/64706
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.