Make the accumulator saturation check reachable - #1040
Open
it-rec wants to merge 1 commit into
Open
Conversation
The three accumulator sensors treat a saturated SunSpec accumulator as unavailable via "decoded_model[key] > SunSpecAccum.LIMIT32". LIMIT32 is 0xFFFFFFFF, and the value is decoded as UINT32, so it can never exceed that limit and the check never fires. Compare with >= so a fully saturated accumulator is actually detected.
it-rec
force-pushed
the
fix/accum-saturation-check
branch
from
August 17, 2026 05:04
7decb15 to
53af248
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three accumulator sensors treat a saturated SunSpec accumulator as unavailable:
SunSpecAccum.LIMIT32is0xFFFFFFFFand the value is decoded as UINT32, so it can never be greater than the limit. The check never fires, and a fully saturated accumulator is reported as a normal value.Changes
Compare with
>=inSolarEdgeACEnergy,MeterVAhIEandMetervarhIE.Testing
Verified by reasoning about the value range, not on hardware: my accumulators are nowhere near saturation, so I cannot produce the condition on a real device. The change is a one-character comparison fix whose current form is unreachable by construction.
Checklist