fix(test): correct expected test invocation#2100
Closed
marxin wants to merge 1 commit intoWebAssembly:mainfrom
Closed
fix(test): correct expected test invocation#2100marxin wants to merge 1 commit intoWebAssembly:mainfrom
marxin wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
In both tested tail-call invocations, the exception is thrown, but caught. That's why we can't use assert_exception.
Contributor
Author
|
Apparently, it's a documented/discussed |
Member
|
Right, the semantics of return_call is to first unwind the current call frame and then call the function. That's what makes it a tail call. It doesn't matter if the current call frame had a handler before, that is gone by the time the next function is called. If a producer wants exceptions from the callee to be caught, it should not generate a tail call. |
Contributor
Author
|
Gotcha, thanks for clarification! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In both tested tail-call invocations, the exception is thrown, but caught. That's why we can't use
assert_exception.