Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bb9c2f4. Configure here.
| "test": "cross-env FORCE_COLOR=1 lerna run test --parallel", | ||
| "test:node": "cross-env FORCE_COLOR=1 lerna run test:node --parallel", | ||
| "test:browsers": "cross-env FORCE_COLOR=1 lerna run test:browsers --parallel", | ||
| "test-debugger": "cross-env FORCE_COLOR=1 lerna run test-debugger --parallel" |
There was a problem hiding this comment.
React override version conflicts with lockfile resolution
Medium Severity
The root overrides pin react and react-dom to "19.2.0", but the updated package-lock.json now resolves both to 19.2.4 (with the "peer" flag removed). This mismatch was introduced by this PR's lockfile changes, likely a side effect of adding vitest as a production dependency which altered how npm resolves the dependency tree. The override is no longer being honored.
Reviewed by Cursor Bugbot for commit bb9c2f4. Configure here.


Jira Link
Description
Adds browser-based Vitest suites (Playwright: Chromium, Firefox, WebKit) for
@web3auth/no-modaland@web3auth/modal, with tests living under each package’stest/folder.test/configs/browsers.config.mts):loadEnv("test", <packageRoot>, "VITE_")plusdefineforprocess.env.VITE_APP_INFURA_PROJECT_KEYso dependencies that read Infura env at load time work in the browser.test/setup/browser-polyfills.ts): ensuresglobalThis.processexists so SDK / dependency code that touchesprocess.env(e.g.WEB3AUTH_VERSION) does not throw in the browser runner.src/**/*.{ts,tsx}as appropriate.server.fs.allowfor the monorepo root (hoistednode_modules) andoptimizeDeps.includefor React/UI-related deps to avoid mid-run Vite reloads and flaky dynamic imports in browser mode.import/no-extraneous-dependenciesforpackages/**/test/**; modal package eslint targets./test/configs/browsers.config.mtsfor devDependency resolution..env.test.examplein each package documents optionalVITE_APP_INFURA_PROJECT_KEYfor local.env.test.no-modal tests cover
Web3AuthNoModal,BaseConnector, and shared helpers/mocks. Modal tests coverWeb3Auth(modal manager) andLoginModalUI (mount/open).How has this been tested?
cd packages/no-modal && npm test— Vitest browser run (3 browsers) with coverage; all tests passing.cd packages/modal && npm test— same; all tests passing.npm test(Lerna paralleltestin workspaces) should run both package test scripts.Screenshots (if appropriate)
N/A — test and tooling changes only; no end-user UI product changes.
Types of changes
Checklist
.env.test.exampleper package; no separate doc site update.)Note
Medium Risk
Mostly adds test infrastructure and new browser-run test suites, but it also changes how tests are executed (removes node configs / per-package scripts) and introduces a new dependency plus a large
package-lock.jsonchurn that could affect CI installs.Overview
Adds browser-based Vitest (Playwright) test coverage for
@web3auth/no-modaland@web3auth/modal, including newtest/helpers/mocks and suites that exercise key connector/Web3Auth flows plus a basicLoginModalUI mount/open check.Updates Vitest browser configs to load
VITE_env via Vite, injectVITE_APP_INFURA_PROJECT_KEY, allow monorepo-root FS access, and (for modal) pre-bundle heavy UI deps to reduce flakiness; coverage reporting is expanded and test-only files are excluded.Aligns tooling around the new test layout by relaxing ESLint’s
import/no-extraneous-dependenciesforpackages/**/test/**, simplifying root and packagetestscripts to run the browser config, adding.env.test.examplefiles, and updating dependencies/lockfile (including addingox).Reviewed by Cursor Bugbot for commit 8cc7bc4. Bugbot is set up for automated code reviews on this repo. Configure here.