Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lwin-kyaw
changed the base branch from
master
to
feat/External-wallet-session-management
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -0,0 +1,2 @@ | |||
| registry=https://registry.npmjs.org/ | |||
|
|
|||
There was a problem hiding this comment.
.npmrc committed despite being in .gitignore
Medium Severity
The .npmrc file is listed in .gitignore (line 115), indicating it's intended to be a local-only configuration file. It was force-committed with registry=https://registry.npmjs.org/, which can override private registry configurations for other contributors and CI environments that rely on consensys.jfrog.io (as seen in the lockfile resolved URLs).
Reviewed by Cursor Bugbot for commit 24591ca. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7506233. Configure here.
| </Button> | ||
| <Button | ||
| v-if="canUnlinkConnectedWallet(account)" | ||
| :loading="accountLinkingLoading && pendingUnlinkAddress === account.address" |
There was a problem hiding this comment.
Unlink button loading state uses wrong property
Medium Severity
The unlink button's :loading binding compares pendingUnlinkAddress === account.address, but pendingUnlinkAddress is set to account.eoaAddress (via onUnlinkAccount(account.eoaAddress) on the click handler). address (from LinkedAccountInfo, nullable) and eoaAddress (from ConnectedAccountInfo) are distinct fields, so the loading spinner will never display for the unlink button when the two values differ.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7506233. Configure here.
| const lastUnlinkedAddress = ref<string | null>(null); | ||
| const pendingUnlinkAddress = ref<string | null>(null); | ||
| const connectedWallets = computed(() => userInfo.value?.connectedAccounts ?? []); | ||
| console.log("connectedWallets", connectedWallets.value); |
There was a problem hiding this comment.
Debug console.log left in component setup
Low Severity
A console.log("connectedWallets", connectedWallets.value) statement sits at the top level of <script setup>, so it runs on every component mount. This looks like leftover debug output that wasn't intended for the final commit.
Reviewed by Cursor Bugbot for commit 7506233. Configure here.
1 participant
Jira Link
https://consensyssoftware.atlassian.net/browse/EMBED-85?atlOrigin=eyJpIjoiM2UxZDY3YTZlOGFkNGU2Nzg0YjFjYjliOTc5N2I1MjAiLCJwIjoiaiJ9
Description
This PR adds external wallet account linking to Web3Auth.
Users authenticated through the
AUTHconnector can now link and unlink external wallets, retrieve connected account metadata from user info, and access framework-level React/Vue helpers for the flow. The change also updates the demo apps to showcase the new linking UX.What Changed
linkAccount(params)andunlinkAccount(address)toWeb3AuthNoModal./v1/link/walletand/v1/unlink/walletrequests.AccountLinkingErrorerror codes and analytics events for linking/unlinking start, success, and failure.generateChallengeAndSign()so external wallets can produce proof-of-ownership signatures for linking.AuthConnector.getUserInfo()to includeconnectedAccountsfetched from Citadel/v1/user.useLinkAccounthooks/composables for:@web3auth/modal/react@web3auth/modal/vue@web3auth/no-modal/react@web3auth/no-modal/vueUser-Facing Features
useLinkAccountAPI with loading, error, and linked account state.Notes
AUTHconnector.METAMASKandWALLET_CONNECT_V2.How has this been tested?
AUTHconnector.getUserInfo()and verifyconnectedAccountsis returned.Screenshots (if appropriate)
Types of changes
Checklist
Note
High Risk
High risk because it adds new account-linking/unlinking flows tied to authentication tokens and introduces account switching that mutates the active connection/provider state, which can impact session integrity and downstream integrations (e.g. Wagmi).
Overview
Adds account linking/unlinking support to
@web3auth/no-modalvia new account-linking types + REST helpers and exposesweb3Auth.linkAccount()/web3Auth.unlinkAccount()APIs, alongside analytics events and dedicatedAccountLinkingErrorcodes.Introduces active connected-wallet switching (
web3Auth.switchAccount()anduseSwitchAccountReact/Vue helpers) and updates user info to includeconnectedAccounts, with provider/integration resync logic to handle connection updates.Updates demo apps (notably
demo/vue-app-new/AppDashboard.vue) to display connected wallets, link/unlink wallets, and switch the active wallet; also bumps Torus controllers and refreshes lockfile registry resolutions and related dependencies.Reviewed by Cursor Bugbot for commit 37bdd8e. Bugbot is set up for automated code reviews on this repo. Configure here.