Open
Conversation
cf9bd85 to
d960dd3
Compare
Member
Author
.github/CODEOWNERS
Outdated
| * @torusresearch/Admins | ||
|
|
||
| # Product code | ||
| **/src/ @torusresearch/Web3Auth-Product |
Member
Author
There was a problem hiding this comment.
I've fix this, however team @Web3auth/Web3Auth-Admins not existed in Web3auth org, so we need create it.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
.github/CODEOWNERS
Outdated
| * @Web3auth/Web3Auth-Admins | ||
|
|
||
| # Product code | ||
| src/ @Web3auth/Web3Auth-Product |
Member
There was a problem hiding this comment.
you need to use the lerna based folder structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modernize the web3auth-backend Node SDK by upgrading dependencies, migrating the test framework, replacing
etherswithviem, removing Node.jsBufferpolyfills, and adding CI and code ownership configuration.Jira Link:
https://consensyssoftware.atlassian.net/browse/EMBED-29
Description
Test framework migration: Mocha + Chai → Vitest
.mocharc.json,babel.config.js, andtest/setup.mjsvitest.config.mtswith verbose reporter and istanbul coverageexpect(...).to.equal(...)) to Vitest (expect(...).toBe(...))ethers → viem
ethers(Wallet,JsonRpcProvider) withviem(createWalletClient,privateKeyToAccount,http)WalletResultEIP155 signer type fromWallettoWalletClientBuffer polyfill removal
Buffer.from(..., "base64")→Uint8Array.from(atob(...), (c) => c.charCodeAt(0))Buffer.from(..., "utf8")→new TextEncoder().encode(...)Utility update
safeatob→base64toJSONfrom@web3auth/authDependency version bumps
@toruslabs/*,@web3auth/*,@solana/*,@segment/*to latest majorsmocha,chai,tsx,tsconfig-pathsvitest,@toruslabs/torus-scripts>=20.x→>=22.x; npm:>=9.x→>=10.xrimraf dist/ && tsc→torus-scripts buildeslint --fix 'src/**/*.ts'→torus-scripts lint src testCI & CODEOWNERS
.github/workflows/ci.yml(Build, Test & Lint on push, Node 24.x).github/CODEOWNERSwith@torusresearch/Adminsfallback and@torusresearch/Web3Auth-Productfor source/testESLint config
mocha/no-setup-in-describeruleimport/no-extraneous-dependencies: offfor test and config filesHow has this been tested?
TransactionSignernpm run buildandnpm run lintScreenshots (if appropriate):
N/A
Types of changes
Checklist:
Note
Medium Risk
Moderate risk due to CI/build pipeline and Node version baseline changes, which can surface environment-specific failures across packages. No runtime/auth logic is changed in this diff, but the new
JWT_PRIVATE_KEYsecret requirement can break tests if not configured.Overview
Adds repo-level automation and ownership controls. Introduces
.github/workflows/ci.ymlto runbuild,lint, andteston push using Node24.x, passingJWT_PRIVATE_KEYfrom GitHub secrets, and adds a CODEOWNERS policy with admin/product ownership.Updates local/tooling configs. Adds
.env.examplefor test setup, bumps.nvmrcto>=24.x, removes legacy.mocharc.jsonandbabel.config.js, tweakseslint.config.mjsto drop Mocha-specific rules and disableimport/no-extraneous-dependenciesfor tests/config, and slightly tightens.gitignore/.npmignorecache entries.Written by Cursor Bugbot for commit de003e6. This will update automatically on new commits. Configure here.